php Question posted in
Official manual can be found here.

Problem with PHP script displaying array of random files

I am using a PHP script to select a limited number (15) of random files from a directory, then display them on a page. The main problem is it seems to randomly midfire. Every few times I load the page, it displays more files than intended. Not a fatal error, but problematic.

Also, I haven’t figured out a way to get it to not repeat the same files. Relying on the fact that I will eventually have hundreds of files to choose from…

Any ideas? I am not really a coder…

Here is my script:

<?php 

$folder = ($_SERVER['DOCUMENT_ROOT'] . "/rotators/index/"); 

$exts = 'php'; 

$files = array(); $i = -1;  
if ('' == $folder) $folder = './'; 
$handle = opendir($folder); 
$exts = explode(' ', $exts); 
while (false !== ($file = readdir($handle))) { 
foreach($exts as $ext) { 
if (preg_match('/.'.$ext.'$/i', $file, $test)) { 
$files[] = $file; 
++$i; 
}
}
}

shuffle($files);
$random_keys=array_rand($files,15);
require $files[$random_keys[0]];
require $files[$random_keys[1]];
require $files[$random_keys[2]];
require $files[$random_keys[3]];
require $files[$random_keys[4]];
require $files[$random_keys[5]];
require $files[$random_keys[6]];
require $files[$random_keys[7]];
require $files[$random_keys[8]];
require $files[$random_keys[9]];
require $files[$random_keys[10]];
require $files[$random_keys[11]];
require $files[$random_keys[12]];
require $files[$random_keys[13]];
require $files[$random_keys[14]];

?>
Tags:

2

Answers


  1. 0

    I have updated the logic and also added some conditions so that code can be debugged easily.

    One more thing, you have fixed the limit to 15, what if there are less then 15 files? If you are sure there would be at least 15 files inside the folder then keep this.

    Now, this code will load 15 different files each time when a user will refresh the page.

    <?php
$folder = ($_SERVER['DOCUMENT_ROOT'] . "/rotators/index/");
$exts = 'php';
$files = array();

if (is_dir($folder)) {
  $handle = opendir($folder);

  if ($handle) {
    $exts = explode(' ', $exts);

    while (($file = readdir($handle)) !== false) {
      foreach ($exts as $ext) {
        if (preg_match('/.' . $ext . '$/i', $file, $test)) {
          $files[] = $file;
        }
      }
    }

    closedir($handle);

    if (count($files) >= 15) {
      shuffle($files);
      $random_keys = array_rand($files, 15);

      foreach ($random_keys as $key) {
        $file_path = $folder . $files[$key];

        if (file_exists($file_path)) {
          require $file_path;
          echo "<br>";
        } else {
          echo "File not found: " . $files[$key] . "<br>";
        }
      }
    } else {
      echo "Not enough PHP files in the directory.";
    }
  } else {
    echo "Unable to open directory: $folder";
  }
} else {
  echo "Directory does not exist: $folder";
}
?>
    Login or Signup to reply.
  2. 0 
    <?php 
    // Define folder path
    $folder = ($_SERVER['DOCUMENT_ROOT'] . "/rotators/index/"); 
    $exts = 'php'; 
    
    $files = array(); 
    
    // Open the directory
    if (is_dir($folder)) {
        if ($handle = opendir($folder)) {
    
            // Filter for files with the given extension
            while (false !== ($file = readdir($handle))) {
                $path_info = pathinfo($file);
                if (isset($path_info['extension']) && strtolower($path_info['extension']) === $exts) {
                    $files[] = $file;
                }
            }
            closedir($handle);
        }
    }
    
    // Shuffle the array to randomize the file order
    shuffle($files);
    
    // Select the first 15 files, or however many are available
    $random_files = array_slice($files, 0, 15);
    
    // Loop through the selected files and include them
    foreach ($random_files as $file) {
        require $folder . $file;
    }
    ?>

    • use shuffle() to randomise the order

    • use array_slice() to pick the first 15 files

    • add error check to ensure there are enough files to display

    Login or Signup to reply.
Please signup or login to give your own answer.

Back To Top
Search