Android Studio Question posted in
The official documentation can be found here.

Android Studio – setting onClicklistener to multiple buttons

I’m noob in android developing. I’m writing fitness application’s page with trainig excercises. I have many buttons clicking on I want to show popup containing some content different to each button. I have this kode:

val button4day2: Button = view.findViewById(R.id.watch4day2)
        button4day2.setOnClickListener(){
            makePopupDescription(context, R.drawable.pullupsgif,
                context.getString(R.string.pullups_description))
        }

        val button5day2: Button = view.findViewById(R.id.watch5Day2)
        button5day2.setOnClickListener(){
            makePopupDescription(context, R.drawable.triceps_press,
                context.getString(R.string.triceps_press_description))
        }

        val button1day3: Button = view.findViewById(R.id.watch1Day3)
        button1day3.setOnClickListener(){
            makePopupDescription(context, R.drawable.warmupgif,
                context.getString(R.string.warmup_description))
        }

        val button2day3: Button = view.findViewById(R.id.watch2Day3)
        button2day3.setOnClickListener(){
            makePopupDescription(context, R.drawable.squatgif,
                context.getString(R.string.squat_description))
        }

as you see, each button’s id differs only two numbers. and for each button I have a certain gif and string to show in popup. So, how can reduce amount of copy-paste in my code?
I thought I can use lists of buttons, gifs and strings. but how to initialise them quickly, not writing every button’s id in constructor?

P.S: sorry for my bad English

Tags:

2

Answers


  1. 0

    o reduce the amount of copy-pasting in your code, you can indeed use lists or arrays to store the button IDs, drawable resource IDs, and string resource IDs. Then you can iterate through these lists to set up the OnClickListener for each button. This approach will make your code more concise and maintainable.

    Here’s an example of how you can achieve this in Kotlin:

    Create arrays for the button IDs, drawable resource IDs, and string resource IDs.
    Iterate through these arrays and set up the OnClickListener for each button.
    Here’s the updated code:

    // Arrays for button IDs, drawable resource IDs, and string resource IDs

    val buttonIds = arrayOf(R.id.watch4day2, R.id.watch5Day2, R.id.watch1Day3, R.id.watch2Day3)
val drawableIds = arrayOf(R.drawable.pullupsgif, R.drawable.triceps_press, R.drawable.warmupgif, R.drawable.squatgif)
val stringIds = arrayOf(R.string.pullups_description, R.string.triceps_press_description, R.string.warmup_description, R.string.squat_description)

// Iterate through the arrays and set up the OnClickListener for each button
for (i in buttonIds.indices) {
    val button: Button = view.findViewById(buttonIds[i])
    button.setOnClickListener {
        makePopupDescription(context, drawableIds[i], context.getString(stringIds[i]))
    }
}

    In this example:

    buttonIds is an array containing the IDs of the buttons.
    drawableIds is an array containing the drawable resource IDs for the GIFs.
    stringIds is an array containing the string resource IDs for the descriptions.
    The for loop iterates through the indices of the buttonIds array, and for each index, it sets up the OnClickListener for the corresponding button

    Login or Signup to reply.
  2. 0

    I thought I can use lists of buttons, gifs and strings.

    Yes you can do so, here’s an example :

    //Buttons array
val buttonIds = arrayOf(
    R.id.watch4day2, R.id.watch5Day2, R.id.watch1Day3, R.id.watch2Day3
)

//Gifs array
val drawableResources = arrayOf(
    R.drawable.pullupsgif, R.drawable.triceps_press, R.drawable.warmupgif, R.drawable.squatgif
)

//StringResources array
val stringResources = arrayOf(
    R.string.pullups_description, R.string.triceps_press_description, R.string.warmup_description, R.string.squat_description
)

    Then you need to create a loop to do the setOnClickListener

    for (i in buttonIds.indices) {
    val button: Button = view.findViewById(buttonIds[i])
    button.setOnClickListener {
        makePopupDescription(
            context,
            drawableResources[i],
            context.getString(stringResources[i])
        )
    }
}

    If you don’t like this option you can create a class

    data class Exercise(val buttonId: Int, val drawableResId: Int, val stringResId: Int)

    Then you initialize the data according your needs

    val exercises = listOf(
    Exercise(R.id.watch4day2, R.drawable.pullupsgif, R.string.pullups_description),
    Exercise(R.id.watch5Day2, R.drawable.triceps_press, R.string.triceps_press_description),
    Exercise(R.id.watch1Day3, R.drawable.warmupgif, R.string.warmup_description),
    Exercise(R.id.watch2Day3, R.drawable.squatgif, R.string.squat_description)
)

    Then loop through all the exercices

    exercises.forEach { exercise ->
    val button: Button = view.findViewById(exercise.buttonId)
    button.setOnClickListener {
        makePopupDescription(
            context,
            exercise.drawableResId,
            context.getString(exercise.stringResId)
        )
    }
}
    Login or Signup to reply.
Please signup or login to give your own answer.

Back To Top
Search