Question 291014 in Android Studio Question posted in
The official documentation can be found here.

Show red line in switch case statement with menu in android studio

I have faced the error code red line under case R.id.item ( Constant expression required ) to find the id from menu.xml and I have tried to find the problem but I was unable to find it.

enter image description here

enter image description here

MainActivity.xml :

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:context=".MainActivity">

<androidx.appcompat.widget.Toolbar
   android:layout_width="match_parent"
   android:layout_height="wrap_content"
   android:background="@color/black"
   app:titleTextColor="@color/white"
   app:title="ToolBar"
   app:menu="@menu/main_menu">

</androidx.appcompat.widget.Toolbar>

</LinearLayout>

Main_menu.xml

<?xml version="1.0" encoding="utf-8"?>
<menu xmlns:android="http://schemas.android.com/apk/res/android">
    <item
        android:id="@+id/menu_item_1"
        android:title="Item 1"/>
    <item
        android:id="@+id/menu_item_2"
        android:title="Item 2"/>
</menu>

MainActivity.class

package com.example.rev_menu;

import android.os.Bundle;
import android.view.Menu;
import android.view.MenuInflater;
import android.view.MenuItem;
import android.widget.Toast;

import androidx.annotation.NonNull;
import androidx.appcompat.app.AppCompatActivity;

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    switch (item.getItemId()) {
        case R.id.menu_item_1:
            Toast.makeText(MainActivity.this, "message 1",         Toast.LENGTH_SHORT).show();
        case R.id.menu_item_2:
            Toast.makeText(MainActivity.this, "message 2", Toast.LENGTH_SHORT).show();
        default:
            return super.onOptionsItemSelected(item);
    }
}
@Override
public boolean onCreatePanelMenu(int featureId, @NonNull Menu menu) {
    MenuInflater inflater = getMenuInflater();
    inflater.inflate(R.menu.main_menu, menu);

    return true;
}
}

Where’s the exact issue?
Note: I tried ( Rebuild project, Clean project, restart the app and create new project 🙂 )

Tags:

2

Answers


  1. Chosen as BEST ANSWER
    0

    thanks for your information, I have tried another way if if ... but it still doesn't take any action when clicking any item from the menu :/

      @Override
public boolean onOptionsItemSelected(MenuItem item) {
    int id = item.getItemId();
    if (id == R.id.menu_item_1) {
        Toast.makeText(MainActivity.this, "item1", Toast.LENGTH_SHORT).show();
    }
    if (id == R.id.menu_item_2) {
        Toast.makeText(MainActivity.this, "item2", Toast.LENGTH_SHORT).show();
    }
    return super.onOptionsItemSelected(item);
}

@Override
public boolean onCreatePanelMenu(int featureId, @NonNull Menu menu) {
    getMenuInflater().inflate(R.menu.main_menu, menu);
    return true;
}
}

    enter image description here

    I don't know what is the issue ... thanks


  2. 0

    Since Android Gradle Plugin 8.0, resource IDs are no longer final (see Android Gradle Plugin 8.0 changelog), and you can’t use non-final values a case.

    You can either :

    • Set the android.nonFinalResIds property to false in your gradle.properties file (not recommended),
    • Review your code and switch to a simple if else if statement as mentioned by M DEV.
    Login or Signup to reply.
Please signup or login to give your own answer.

Back To Top
Search