Question 110560 in Json Question posted in
Our archive of expertly curated questions and answers provides insights and solutions to common problems related to this popular data interchange format. From parsing and manipulating JSON data to integrating it with various programming languages and web services, our archive has got you covered. Start exploring today and take your JSON skills to the next level

Json – I get a StopIteration error when not finding a value with generator expressions

Well, I have a json file that I load in a variable and if the file doesn’t exist, I make a dictionary that will soon become the json file. So good, I’m trying to look for specific elements of this dictionary and that’s why I’m using generator expressions.

This is how I use it:

Data = json.load(open(file)) if isfile("data.json") else {"News": {},"Records": {},"Profiles": []}

name = "asdadsefttytryrty"

get = next(get for get in Data["Profiles"] if get["Name"] == name or get["ID"] == name)

and the dictionary data would be something like this:

{
    "News": {},
    "Records": {},
    "Profiles": [
        {
            "Name": "123rd453",
            "ID": "1",
            "Password": "dfsdfee",
            "Image": "image"
        },
        {
            "Name": "asdadsefttytryrty",
            "ID": "2",
            "Password": "12345",
            "Image": "image"
        }
    ]
}

So okay, this has a problem if the element I’m looking for doesn’t exist: StopIteration

So to check that the element exists, I wanted to do an if-else to perform certain operations, but I couldn’t. So I decided to use try-except as a temporary solution and I don’t think it’s reliable.

Data = json.load(open(file)) if isfile("data.json") else {"News": {},"Records": {},"Profiles": []}

name = "asdadsefttytryrty"
try:
    get = next(get for get in Data["Profiles"] if get["Name"] == name or get["ID"] == name)
    print("exist")
except:
    print("Doesn't exist")

Doing this is correct?

Tags:

2

Answers


  1. 0

    Don’t make things complicated. You can simply do this:

    from os import path

data = {}
name = "asdadsefttytryrty"

if (path.exists("./data.json")):
    with open('data.json') as f:
        data = json.load(f)
else:
    data = {
        "News": {},
        "Records": {},
        "Profiles": []
    }

if name in data["Profiles"]:
    print("Exists")
else:
    print("Doesn't exist")

    Use the path.exists() method from os module to check if a certain path exists.

    Declaring variables at the start is a good practice.

    Login or Signup to reply.
  2. 0

    next does raise StopIteration when the given iterator is exhausted, so what you’re doing is basically correct and reliable, with the only thing to add being the specific exception you’re expecting, in order not to catch unexpected exceptions such as KeyboardInterrupt:

    try:
    get = next(get for get in Data["Profiles"] if get["Name"] == name or get["ID"] == name)
    print("exist")
except StopIteration:
    print("Doesn't exist")

    That said, in this case the code would arguably be cleaner and more readable written with a for-else construct instead:

    for get in Data["Profiles"]:
    if name in (get["Name"], get["ID"]):
        print("Exists")
        break
else:
    print("Doesn't exist")
    Login or Signup to reply.
Please signup or login to give your own answer.

Back To Top
Search